Fix bug in tuyaModernExtend #8435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array containing an undefined is truthy. Correction to ensure value is falsy.
tuyaModernExtend can be used, feel free to create a PR. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #8190 and prevents
tuyaModernExtendfunctioning when no endpoint is specified. Low impact as almost no converters use this yet.When endpoint is undefined, array is still truthy. Correction to ensure value is falsy when zigbee2mqtt is matching the converter.
I now have a converter working for a garage door opener if
tuyaModernExtendis ready to be used more widely?